Move Line Item Actions to solidus_legacy_promotions#5916
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Nov 14, 2024
Merged
Move Line Item Actions to solidus_legacy_promotions#5916tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
This table belongs to the legacy promotion system and was, unfortunately, missed in the original extraction.
github-actions
Bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5916 +/- ##
==========================================
- Coverage 89.54% 89.54% -0.01%
==========================================
Files 783 782 -1
Lines 17994 17988 -6
==========================================
- Hits 16113 16107 -6
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
Nov 13, 2024
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Ah, thanks! We cannot be sure that the migration has not already ran for folks. I think we should introduce a new migration file for this table
tvdeyen
approved these changes
Nov 14, 2024
tvdeyen
added
backport-v4.4
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kennyadsl
approved these changes
Nov 14, 2024
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
👍 going in the next patch level release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This table belongs to the legacy promotion system and was, unfortunately, missed in the original extraction.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: