Remove rails binstubs from built gems#5917
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Nov 14, 2024
Merged
Conversation
The bin/rails script is solely used for local dev purposes. Since the default bindir from Rubygems is bin the binstub gets installed with the gems. This can cause issues with the rails command comming from rails itself. Also removing the old script/rails files, which were excluded to solve the same issue.
github-actions
Bot
added
changelog:solidus_api
Member
Author
|
Excerpt from current --- !ruby/object:Gem::Specification
name: solidus_legacy_promotions
[...]
bindir: bin
[...]
files:
[..]
- bin/rails
[...]which reveals that |
tvdeyen
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5917 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 783 783
Lines 17994 17994
=======================================
Hits 16113 16113
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Nov 14, 2024
adammathys
approved these changes
Nov 14, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bin/railsscript is solely used for local dev purposes. Since the defaultbindirfrom Rubygems isbinthe binstub gets installed with the gems. This can cause issues with therailscommand coming from rails itself.Also removing the old
script/railsfiles, which were excluded to solve the same issue.