Fix component translation scopes#5927
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Nov 15, 2024
Merged
Conversation
Contributor
Author
|
Build error is unrelated, I think. Can I have a new build? |
In the `view_component` gem, the `i18n_scope` for a component depends on the file name of the component, and removes `app_components` and everything before that in order to construct a scope. This fails to work with components that live in `lib/components/admin/`, as with our extensions, as there is no `app/components` in the path to these components. This change uses the class name instead, which should be easier on memory and correctly works with components from solidus extensions. This also fixes translations in inherited components, allowing to delete some redundant translations in the promotion gem's `order` component.
mamhoff
force-pushed
the
fix-component-translation-scope
branch
from
14c4da5 to
46e8250
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5927 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 782 782
Lines 17980 17982 +2
=======================================
+ Hits 16099 16101 +2
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Nov 15, 2024
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
Makes sense, thanks Martin!
tvdeyen
added
backport-v4.4
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
view_componentgem, thei18n_scopefor a component depends on the file name of the component, and removesapp_componentsand everything before that in order to construct a scope.This fails to work with components that live in
lib/components/admin/, as with our extensions, as there is noapp/componentsin the path to these components.This change uses the class name instead, which should be easier on memory and correctly works with components from solidus extensions.
This also fixes translations in inherited components, allowing to delete some redundant translations in the promotion gem's
ordercomponent.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: