Only set promo configuration to legacy if no other set#5928
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Nov 15, 2024
Merged
Only set promo configuration to legacy if no other set#5928tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
github-actions
Bot
added
the
changelog:repository
mamhoff
force-pushed
the
only-set-legacy-promo-config-if-none-set
branch
from
07f7f78 to
b5688a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5928 +/- ##
==========================================
+ Coverage 87.81% 89.54% +1.72%
==========================================
Files 476 782 +306
Lines 11656 17988 +6332
==========================================
+ Hits 10236 16107 +5871
- Misses 1420 1881 +461 ☔ View full report in Codecov by Sentry. |
tvdeyen
added
backport-v4.4
tvdeyen
approved these changes
Nov 15, 2024
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Can we remove the white space changes?
This sets the promotion configuration to the legacy promotion system if no other promotion system, like `solidus_promotion` has been configured in the `spree` initializer. This should get rid of errors people encounter when trying to use `solidus_promotions`, but the system being reconfigured without their intervention to use the legacy system.
mamhoff
force-pushed
the
only-set-legacy-promo-config-if-none-set
branch
from
a8c4c64 to
f4d24f2
Compare
github-actions
Bot
added
the
changelog:repository
tvdeyen
removed
the
changelog:repository
Member
|
Backport after #6016 |
tvdeyen
added
backport-v4.4
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the promotion configuration to the legacy promotion system if no other promotion system, like
solidus_promotionhas been configured in thespreeinitializer.This should get rid of errors people encounter when trying to use
solidus_promotions, but the system being reconfigured without their intervention to use the legacy system.Here's the problem this should solve:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: