Merged
Conversation
3 tasks
mamhoff
force-pushed
the
better-promotion-menus
branch
from
98ccbd7 to
bab02aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5934 +/- ##
==========================================
- Coverage 89.53% 87.81% -1.73%
==========================================
Files 782 476 -306
Lines 17981 11656 -6325
==========================================
- Hits 16100 10236 -5864
+ Misses 1881 1420 -461 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
Nov 17, 2024
This makes sure that the promotion menus are always below the product menu item, in both new admin and the backend. It also changes the nomenclature to be "Promotions" for the legacy promotion system and "Promotions (new)" for the new promotion system.
Prior to this commit, the new promotion system would exchange the promotion and promotion category index page components if the gem was loaded. This made it impossible to actually see the old promotion configuration when using the new admin. This commit now only changes the orders/index component if the new promotion system is activated. In any case, it will display new promotion and promotion category records under "Promotions (new)".
mamhoff
force-pushed
the
better-promotion-menus
branch
from
bab02aa to
0a69b6a
Compare
github-actions
Bot
added
changelog:solidus_legacy_promotions
Member
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR, built on top of #5933 , allows viewing the configuration of both the legacy promotion system and the new promotion system side-by-side in the new admin, with pleasing menu items.
Instead of "Legacy Promotions", which looks a bit bad (why does the system come with "legacy" by default?), we call those just "Promotions", and the new Promotion system is termed "Promotions (new).
There's also fixes in here for always showing the promotions menu items in the same sequence below the products menu item.