Skip to content

[v4.4] Use new global variables stylesheet in legacy promotions#5935

Merged
tvdeyen merged 1 commit intov4.4from
backport/v4.4/pr-5932
Nov 18, 2024
Merged

[v4.4] Use new global variables stylesheet in legacy promotions#5935
tvdeyen merged 1 commit intov4.4from
backport/v4.4/pr-5932

Conversation

@github-actions
Copy link
Copy Markdown

Backport

This will backport the following commits from main to v4.4:

Questions ?

Please refer to the Backport tool documentation

Prior to this change, the promotion admin would have a blue color
scheme, and not the red one that all the other pages have.

(cherry picked from commit 21bb837)
@github-actions github-actions Bot requested a review from a team as a code owner November 16, 2024 13:01
@github-actions github-actions Bot added changelog:repository Changes to the repository not within any gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem type:bug Error, flaw or fault labels Nov 16, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.28%. Comparing base (5ce0c99) to head (0f5d280).
Report is 2 commits behind head on v4.4.

Additional details and impacted files
@@            Coverage Diff             @@
##             v4.4    #5935      +/-   ##
==========================================
- Coverage   89.53%   89.28%   -0.26%     
==========================================
  Files         782      711      -71     
  Lines       17982    16174    -1808     
==========================================
- Hits        16101    14441    -1660     
+ Misses       1881     1733     -148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit b9abfce into v4.4 Nov 18, 2024
@tvdeyen tvdeyen deleted the backport/v4.4/pr-5932 branch November 18, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:repository Changes to the repository not within any gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem type:bug Error, flaw or fault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants