Skip to content

[v4.4] Backend: Add missing error translation#5986

Merged
tvdeyen merged 1 commit intov4.4from
backport/v4.4/pr-5979
Dec 3, 2024
Merged

[v4.4] Backend: Add missing error translation#5986
tvdeyen merged 1 commit intov4.4from
backport/v4.4/pr-5979

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot commented Dec 3, 2024

Backport

This will backport the following commits from main to v4.4:

Questions ?

Please refer to the Backport tool documentation

We were missing a translation here, but never noticed, because we were
not testing for an actual human-understandable string.

This is broken in the v4.0, v4.1, v4.2 and v4.3 branches with a noisier
error message, because in those branches, `I18n.t("unavailable")` is
different from `t("unavailable")`.

(cherry picked from commit 506ddfc)
@github-actions github-actions Bot requested a review from a team as a code owner December 3, 2024 11:25
@github-actions github-actions Bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Dec 3, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (b2eff15) to head (f9d7587).
Report is 2 commits behind head on v4.4.

Additional details and impacted files
@@           Coverage Diff           @@
##             v4.4    #5986   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files         782      782           
  Lines       17991    17991           
=======================================
  Hits        16094    16094           
  Misses       1897     1897           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 1fc456f into v4.4 Dec 3, 2024
@tvdeyen tvdeyen deleted the backport/v4.4/pr-5979 branch December 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants