[v4.3] test: Wait for modal to open before testing its content#5995
Merged
[v4.3] test: Wait for modal to open before testing its content#5995
Conversation
If the modal cannot be openend after 5 seconds (Capybara default wait tiem is 3 seconds) then something is wrong. We must not waste precious resources and time for a buld to fail. (cherry picked from commit 7112488) # Conflicts: # promotions/spec/system/solidus_promotions/admin/promotions_spec.rb
tvdeyen
added
backport-v4.2
tvdeyen
removed
backport-v4.2
jarednorman
approved these changes
Dec 4, 2024
MadelineCollier
approved these changes
Dec 4, 2024
Contributor
MadelineCollier
left a comment
MadelineCollier
left a comment
There was a problem hiding this comment.
Might also want to backport this: #5998
tvdeyen
added
backport-v4.4
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
removed
backport-v4.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.3:Questions ?
Please refer to the Backport tool documentation