[v4.1] Do not constantize Spree.user_class in UserClassHandle#6001
Merged
[v4.1] Do not constantize Spree.user_class in UserClassHandle#6001
Conversation
`Spree.user_class` will constantize the configured user class. If called during Rails start-up, this will autoload the configured user class, `Spree.user_class`. We can do without the autoloading by directly getting the name of the class from a new method `Spree.user_class_name`. (cherry picked from commit 355ba7a)
github-actions
Bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.1 #6001 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 123 123
Lines 3285 3285
=======================================
Hits 3064 3064
Misses 221 221 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.1:Questions ?
Please refer to the Backport tool documentation