Skip to content

[v4.3] Do not constantize Spree.user_class in UserClassHandle#6003

Merged
tvdeyen merged 1 commit intov4.3from
backport/v4.3/pr-5999
Dec 4, 2024
Merged

[v4.3] Do not constantize Spree.user_class in UserClassHandle#6003
tvdeyen merged 1 commit intov4.3from
backport/v4.3/pr-5999

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot commented Dec 4, 2024

Backport

This will backport the following commits from main to v4.3:

Questions ?

Please refer to the Backport tool documentation

`Spree.user_class` will constantize the configured user class. If called
during Rails start-up, this will autoload the configured user class,
`Spree.user_class`. We can do without the autoloading by directly getting the name
of the class from a new method `Spree.user_class_name`.

(cherry picked from commit 355ba7a)
@github-actions github-actions Bot requested a review from a team as a code owner December 4, 2024 14:30
@github-actions github-actions Bot added the changelog:solidus_core Changes to the solidus_core gem label Dec 4, 2024
@tvdeyen tvdeyen merged commit 2eb1fc1 into v4.3 Dec 4, 2024
@tvdeyen tvdeyen deleted the backport/v4.3/pr-5999 branch December 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants