Skip to content

[v4.4] [specs] Wait for modal before testing its content#6005

Merged
MadelineCollier merged 1 commit intov4.4from
backport/v4.4/pr-5998
Dec 4, 2024
Merged

[v4.4] [specs] Wait for modal before testing its content#6005
MadelineCollier merged 1 commit intov4.4from
backport/v4.4/pr-5998

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot commented Dec 4, 2024

Backport

This will backport the following commits from main to v4.4:

Questions ?

Please refer to the Backport tool documentation

Building off of #5993, a few
more specs required a short wait time to give the modal a chance to
load. They were flaky (failing somewhat regularly in CI, but always
passing locally) and this should help remedy that.

(cherry picked from commit a25a62a)
@github-actions github-actions Bot force-pushed the backport/v4.4/pr-5998 branch 2 times, most recently from a889032 to 8fea128 Compare December 4, 2024 15:30
@MadelineCollier MadelineCollier merged commit b5f5e0a into v4.4 Dec 4, 2024
@MadelineCollier MadelineCollier deleted the backport/v4.4/pr-5998 branch December 4, 2024 15:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (ea8ea89) to head (8fea128).
Report is 2 commits behind head on v4.4.

Additional details and impacted files
@@            Coverage Diff             @@
##             v4.4    #6005      +/-   ##
==========================================
+ Coverage   89.45%   91.81%   +2.35%     
==========================================
  Files         782       71     -711     
  Lines       17991     1808   -16183     
==========================================
- Hits        16094     1660   -14434     
+ Misses       1897      148    -1749     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants