Merged
Conversation
kennyadsl
approved these changes
Dec 5, 2024
Member
kennyadsl
left a comment
There was a problem hiding this comment.
👌 everything here makes sense, thanks.
tvdeyen
approved these changes
Dec 5, 2024
None of this works right now, but let's write a spec that details how things should work.
The promotion class should decide whether it can apply.
This duplicated the logic from SolidusPromotions::Promotion.order_activatable, and this way it reads nicer.
9a9509d to
3588c15
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6013 +/- ##
==========================================
+ Coverage 87.81% 89.46% +1.64%
==========================================
Files 476 782 +306
Lines 11658 18009 +6351
==========================================
+ Hits 10238 16112 +5874
- Misses 1420 1897 +477 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Not sure what happened to the Backport PR? I don't see it? |
Member
|
I tried to retrigger the flow but it's still skipping it. I don't think we changed anything there recently, so it might a temporary issue with GitHub Actions. |
Member
|
Should be fixed by #6016 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the orders/adjustment pages when using the new promotion system.
Bug report from @boomer196 on Slack: