Merged
Conversation
This allows to run prettier in your editor
Adjust the syntax of all admin js files to prettier config.
3 tasks
kennyadsl
approved these changes
Dec 20, 2024
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
Thanks @tvdeyen!
Unrelated: do we need the chore(admin): part in the commit message? I don't think we ever used this format before, and we have the changelog tag already indicating where the change has effect. Despite I don't particularly like this format, I don't have strong preferences and I'm ok with you committing this way if you prefer. ❤️
Member
Author
|
I don't mind changing it, but auto merge was already enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a prettier config and adjust all admin JS files to the syntax rules.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: