Fix unsafe html view component, allow ViewComponent 3.21+#6055
Merged
tvdeyen merged 2 commits intosolidusio:mainfrom Jan 6, 2025
Merged
Fix unsafe html view component, allow ViewComponent 3.21+#6055tvdeyen merged 2 commits intosolidusio:mainfrom
tvdeyen merged 2 commits intosolidusio:mainfrom
Conversation
The mock component in the ComponentHelpers module was not a real constant, which messes with ViewComponent's expectations about what render_inline is given. Using `stub_const` in the helper allows us to give it an actual name, and view_component > 3.21.0 will work for us. The helper is only used in the base component spec. I could have spent more time giving it an optional block, but this solution is the most straightforward.
mamhoff
force-pushed
the
fix-unsafe-html-view-component
branch
from
4411534 to
7bd0860
Compare
tvdeyen
approved these changes
Jan 3, 2025
adammathys
approved these changes
Jan 3, 2025
tvdeyen
added
backport-v4.1
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Member
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Member
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the
mock_componenthelper to always mock an actual constant, rather than just stubbing the name on it. view_component expects components to be actual things.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: