Make state machine modules auto-loadable#6056
Merged
tvdeyen merged 2 commits intosolidusio:mainfrom Jan 9, 2025
Merged
Conversation
github-actions
Bot
added
the
changelog:solidus_core
3 tasks
jarednorman
approved these changes
Jan 8, 2025
kennyadsl
approved these changes
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6056 +/- ##
==========================================
- Coverage 89.59% 89.57% -0.02%
==========================================
Files 791 791
Lines 18269 18234 -35
==========================================
- Hits 16368 16333 -35
Misses 1901 1901 ☔ View full report in Codecov by Sentry. |
Member
|
@mamhoff maybe we should add the same "deprecate lib file" pattern here for the moved files? |
This moves the default state machine modules into `app`, making them autoloadable. In order to accomplish that, I had to change the superclass of `Spree::Core::StateMachines` to a `Spree::Preferences::Configuration`, so that the `class_name_attribute` method is available. Technically, we're using it for modules here, but that does not actually matter in this context. We just need it to run `constantize`. This also removes some custom "autoloading" code that is not actually all that necessary. The configuration interface stays the same.
mamhoff
force-pushed
the
state-machine-config-autoloadable
branch
from
01d378b to
faead11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This moves the default state machine modules into
app, making them autoloadable. In order to accomplish that, I had to change the superclass ofSpree::Core::StateMachinesto aSpree::Preferences::Configuration, so that theclass_name_attributemethod is available. Technically, we're using it for modules here, but that does not actually matter in this context. We just need it to runconstantize.This also removes some custom "autoloading" code that is not actually all that necessary. The configuration interface stays the same.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: