Remove Display Order from side menu#6119
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Feb 18, 2025
Merged
Conversation
github-actions
Bot
added
changelog:solidus_backend
chaimann
force-pushed
the
remove-display-order-from-nav
branch
from
55dbc51 to
1f8db2b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6119 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 512 512
Lines 11838 11838
=======================================
Hits 10248 10248
Misses 1590 1590 ☔ View full report in Codecov by Sentry. |
kennyadsl
reviewed
Feb 13, 2025
chaimann
force-pushed
the
remove-display-order-from-nav
branch
from
1f8db2b to
a9bb92b
Compare
github-actions
Bot
removed
the
changelog:solidus_backend
Removes "Display Order" menu item from side menu as per https://github.com/orgs/solidusio/projects/12/views/1?pane=issue&itemId=52590353. Note: if enabled in initializer, `config.import_menu_items_from_backend!` will still put "Display order" menu item since it is present in legacy backend menu.
chaimann
force-pushed
the
remove-display-order-from-nav
branch
from
a9bb92b to
562142d
Compare
tvdeyen
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes "Display Order" menu item from side menu as per Solidus Admin (view)
Note: if enabled in initializer,
config.import_menu_items_from_backend!will still put "Display order" menu item since it is present in legacy backend menuChecklist