Fix migration typo (missing keyword foreign_key)#6126
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Feb 18, 2025
Merged
Conversation
github-actions
Bot
added
the
changelog:solidus_core
chaimann
force-pushed
the
fix-migration-typo
branch
2 times, most recently
from
d675da4 to
8aa3948
Compare
Also set `primary_taxon_id` column type to be integer to match `spree_taxons.id`
chaimann
force-pushed
the
fix-migration-typo
branch
from
8aa3948 to
709d60d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6126 +/- ##
==========================================
+ Coverage 86.56% 88.66% +2.09%
==========================================
Files 512 833 +321
Lines 11838 18069 +6231
==========================================
+ Hits 10248 16021 +5773
- Misses 1590 2048 +458 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linter failure unrelated, fixed in #6128
So apparently without
foreign_key:keyword, the migration will just create another column called{ to_table: :spree_taxons }_id(i didn't even know this was a valid syntax for the column name haha)Checklist