Skip to content

[Docs] Fix Meta Data Restriction Comment to reflect default setting#6171

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
fthobe:fix-default-meta-data-config
Mar 3, 2025
Merged

[Docs] Fix Meta Data Restriction Comment to reflect default setting#6171
tvdeyen merged 1 commit intosolidusio:mainfrom
fthobe:fix-default-meta-data-config

Conversation

@fthobe
Copy link
Copy Markdown
Contributor

@fthobe fthobe commented Mar 2, 2025

The comment was inconsistent with the default setting. No functional changes have been made.

Summary

The comment related to the configuration of meta data was incorrect.
No functional changes have been made.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

The comment was inconsistent with the default setting. 
No functional changes have been made.
@fthobe fthobe requested a review from a team as a code owner March 2, 2025 19:22
@github-actions github-actions Bot added the changelog:solidus_core Changes to the solidus_core gem label Mar 2, 2025
@tvdeyen tvdeyen added the backport-v4.5 Backport this pull-request to v4.5 label Mar 3, 2025
@tvdeyen tvdeyen merged commit 43b4607 into solidusio:main Mar 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2025

💔 All backports failed

Status Branch Result
v4.5 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 6171

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Copy Markdown
Member

tvdeyen commented Mar 6, 2025

💚 All backports created successfully

Status Branch Result
v4.5

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.5 Backport this pull-request to v4.5 changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants