Fix ui/forms/input component for tag: :textarea#6174
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Mar 3, 2025
Merged
Conversation
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea In HTML, the initial content of a <textarea> is specified between its opening and closing tags, not as a `value` attribute. Therefore we must set `content`, rather than passing `value` for text areas.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6174 +/- ##
=======================================
Coverage 88.81% 88.81%
=======================================
Files 835 835
Lines 18156 18158 +2
=======================================
+ Hits 16125 16127 +2
Misses 2031 2031 ☔ View full report in Codecov by Sentry. |
tvdeyen
added
backport-v4.4
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Contributor
|
@chaimann thank you so much :) |
Member
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6167
Summary
From MDN:
Therefore we must set
content, rather than passingvaluefor text areas.Checklist