Skip to content

Dummy app generator: Only configure app/assets/javascripts if present#6227

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
mamhoff:no-javascripts-in-dummy-apps
May 5, 2025
Merged

Dummy app generator: Only configure app/assets/javascripts if present#6227
tvdeyen merged 1 commit intosolidusio:mainfrom
mamhoff:no-javascripts-in-dummy-apps

Conversation

@mamhoff
Copy link
Copy Markdown
Contributor

@mamhoff mamhoff commented May 5, 2025

Newer versions of Rails generators do not generate the app/assets/javascripts directory. Let's not add it to the Sprockets config if it's not there.

Newer versions of Rails generators do not generate the
`app/assets/javascripts` directory. Let's not add it to the Sprockets
config if it's not there.
@mamhoff mamhoff requested a review from a team as a code owner May 5, 2025 13:19
@github-actions github-actions Bot added the changelog:solidus_core Changes to the solidus_core gem label May 5, 2025
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We paired on this

@tvdeyen tvdeyen enabled auto-merge May 5, 2025 13:19
@tvdeyen tvdeyen merged commit a85ae3c into solidusio:main May 5, 2025
20 of 22 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (61f675e) to head (ca1af55).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
core/lib/generators/spree/dummy/dummy_generator.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6227      +/-   ##
==========================================
- Coverage   88.80%   88.80%   -0.01%     
==========================================
  Files         842      842              
  Lines       18244    18245       +1     
==========================================
  Hits        16202    16202              
- Misses       2042     2043       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2025

💚 All backports created successfully

Status Branch Result
v4.5

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions github-actions Bot mentioned this pull request May 30, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.5 Backport this pull-request to v4.5 changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants