Draft
Conversation
github-actions
Bot
added
changelog:solidus_backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6437 +/- ##
==========================================
+ Coverage 89.66% 89.68% +0.01%
==========================================
Files 990 991 +1
Lines 20793 20816 +23
==========================================
+ Hits 18645 18668 +23
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Currently we just see a Ruby stacktrace and not any usefull hint on what linting error happened in a PR. This adds GitHub comments and stops redirecting all output to stdout, but use the --out instead for the results.xml.
These were using deprecated Node 20 action syntax, which produces a lot of annoying warnings in the CI
The GH action linter flagged this and it is actually very useful
By including this module into a controller it will run all controller actions within the defined timezone. The timezone is taken from the params, the session, user preference (if existing), or the default timezone of the app. The resolved timezone is then stored in the session for future reference.
tvdeyen
force-pushed
the
timezone-select
branch
2 times, most recently
from
50eda57 to
96ce820
Compare
Use the `Spree::Core::ControllerHelpers::Timezone` module to wrap all admin actions inside the selected timezone.
Use the `Spree::Core::ControllerHelpers::Timezone` module to wrap all admin actions inside the selected timezone. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Spans do not self close and this actually has a closing tag anyway. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
tvdeyen
force-pushed
the
timezone-select
branch
from
96ce820 to
7a2233e
Compare
If the user has a timezone column we show a select to let admins set the preferred time zone of the user.
If the user has a timezone column we show a select to let admins set the preferred time zone of the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a timezone select into the various admin/backend navigations we have. Allows for users to see dates in the admin in the selected timezone. If the current solidus user record has a preferred timezone this is used instead. The resolved timezone is stored in the users session.
This includes a huge update the vendored remixicon sprite (from 3.4.0 to 4.9.1), which has a time zone icon.
This also changes the locale select icon from a globe to the official language icon.
It probably makes sense to extract the two changes into separate PRs.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: