Handle duplicate base_codes in PromotionMigrator#6441
Open
jarednorman wants to merge 1 commit intosolidusio:mainfrom
Open
Handle duplicate base_codes in PromotionMigrator#6441jarednorman wants to merge 1 commit intosolidusio:mainfrom
jarednorman wants to merge 1 commit intosolidusio:mainfrom
Conversation
PromotionMigrator#copy_promotion_codes joined legacy and new promotion_code_batches on base_code alone, which is not unique across promotions; unrelated batches sharing a base_code multiplied rows in the INSERT ... SELECT and triggered PG::UniqueViolation on index_solidus_promotions_promotion_codes_on_value. Constrain the join on promotion_id and created_at so each legacy code resolves to the correct new batch for the promotion being migrated.
github-actions
Bot
added
the
changelog:solidus_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6441 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 990 990
Lines 20792 20792
=======================================
Hits 18644 18644
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just #6422, but with commits combined and reworded to not be so verbose. Credit to @NewAlexandria for the original change.