Skip to content

Preserve Tailwind's default blue color scale#6453

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
BeastNectus:preserve-tailwind-blue-scale
Apr 27, 2026
Merged

Preserve Tailwind's default blue color scale#6453
tvdeyen merged 1 commit intosolidusio:mainfrom
BeastNectus:preserve-tailwind-blue-scale

Conversation

@BeastNectus
Copy link
Copy Markdown
Contributor

Summary

  • rename Solidus Admin's custom blue palette entry to solidus-blue
  • keep .body-link using the Solidus brand color through the new namespaced token
  • stop shadowing Tailwind's default blue-* color scale in host apps using the Solidus Admin preset

Closes #6405

Notes

Tailwind presets merge theme extensions into the host app. Defining colors.blue as a single hex value removes the default blue-50 through blue-950 scale, so standard utilities such as bg-blue-600 are unavailable. A namespaced token keeps Solidus Admin's brand color without taking over Tailwind's blue scale.

Testing

  • node -c admin/config/tailwind.config.js
  • git diff --check

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (9956911) to head (8e81562).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6453   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         990      990           
  Lines       20793    20793           
=======================================
  Hits        18645    18645           
  Misses       2148     2148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jarednorman jarednorman requested a review from a team April 27, 2026 11:37
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how the admin tailwind config messes with the frontend TW config (if this is the issue you are trying to solve?)

Copy link
Copy Markdown
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. We actually extend the Storefronts TW config with our admin theme config. This is not good and should be revisited. But for now, this solves an actual bug. Thank you

@tvdeyen tvdeyen merged commit 026898a into solidusio:main Apr 27, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Tailwind config overrides default blue color scale, breaking Tailwind ecosystem compatibility

3 participants