Simplify Spree::TaxRate#compute_amount#684
Merged
Conversation
The current taxation system does this strange trick when refunding VAT: When there should be a refund because the order's tax zone is outside the default vat zone, the computed amount is turned negative. This commit makes this behaviour a little bit clearer.
Contributor
|
Reads much better to me 👍 |
Contributor
|
Agreed, thanks @mamhoff. You're doing amazing things for the codebase but you're terrible at taking vacations 👎 . |
cbrunsdon
added a commit
that referenced
this pull request
Jan 12, 2016
Simplify `Spree::TaxRate#compute_amount`
Contributor
Author
|
Really? I think I'm having a pretty good time :)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current taxation system does this strange trick when refunding
VAT: When there should be a refund because the order's tax zone
is outside the default vat zone, the computed amount is turned negative.
This commit makes this behaviour a little bit clearer.