Improve i18n in return authorization views.

[Murph33]

Use model name and model attribute translations where logical.

This is part of an ongoing effort to improve I18n use in solidus as discussed in #735.

[cbrunsdon]

I think we generally use Spree::StockLocation.human_name for these, no?

[Murph33]

Yeah. This wasn't merged in yet but it would be taken care of https://github.com/solidusio/solidus/pull/876/files#diff-3 if it's merged first or need to be rebased to take care of. I did this wrong in a number of places (every place in that PR) but since some were merged and some not I thought it made the most sense to handle it all in one PR and rebase as necessary.

Either way I can handle this change now instead of pushing something into master just to immediately change it.

[Murph33]

So I tossed those other translations into new translations on model attributes that don't have corresponding column in the DB but if we want to do that I might need to take another sweep through the forms to be consistent because I'm pretty sure there are still some Spree.t( ) translations in table headers.

[tvdeyen]

Spree.t translations are not evil per se. If the key is specific enough, it's ok to use them.

We should avoid them as much as possible, but "Ausnahmen machen die Regel", as Germans say.

[mamhoff]

This column does not exist anymore, and is not used for refunds anymore either (see #941 and #706).

Besides, it's use further up is for a return item form, not a line item form.

[mamhoff]

I'd say let's go on a case-by-case basis here. Aside from the comments I made regarding amount vs. pre_tax_amount, this PR is 👍 by me.

[mamhoff]

👍

[mamhoff]

@Murph33 Would you mind rebasing this on current master?

[mamhoff]

Thanks!