Merged
Conversation
added 6 commits
June 10, 2015 11:11
Member
|
Looks good. 👍 |
Contributor
|
👍 |
added 2 commits
June 11, 2015 10:31
Replaces the individual rake tasks for building, installing, and deploying gems with a simpler system in the top level Rakefile. Existing tasks were a mix of the PackageTask shipping with rubygems, and the bundler supplied GemHelpers. PackageTask worked fine, but did very little, and had a lot of output and temporary files left in pkg. GemHelpers were installed on all projects other than sample, but supplied a rake release, which did entirely the wrong thing for our project (tag and push to github, but only release one of the gems). The replacement should be simpler, always building/installing/releasing all 6 gems, and keeping their generated gems in the same place (toplevel pkg), and should remove confusion about whether we're building the toplevel solidus gem, or all of the project's gems.
sh will fail when there is an exception, only difference here is that it will print out "rspec", which I consider to be an improvement.
jhawthorn
force-pushed
the
rakefile_cleanup
branch
from
c562916 to
336104d
Compare
3 tasks
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 26, 2024
Use Remix icons if Solidus' admin_updated_navbar is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the redundant per-subproject gem building tasks with an improved central task. Should avoid confusion between
rake build(build just the solidus gem) vsrake gem:build(build all solidus gems).Also prefers using the output from rake helpers (like that from
shandrm_f) to manual puts output.