Only check once whether we're in a non-default non-order zone#913
Merged
gmacdougall merged 1 commit intomasterfrom Mar 3, 2016
unknown repository
Merged
Only check once whether we're in a non-default non-order zone#913gmacdougall merged 1 commit intomasterfrom unknown repository
gmacdougall merged 1 commit intomasterfrom
unknown repository
Conversation
When calling Spree::TaxRate#adjust, Spree::TaxRate#compute_amount will come up with negative amount only if we're processing a refund. This commit checks for the amount of the reimbursement to be negative instead of running a rather expensive call to Spree::Zone.contains.
Contributor
|
👍, its slightly unclear why that check is happening to anyone not deeply familiar with this chunk of code, but as we are (lols, "we") working on removing it entirely I'm cool with it |
Contributor
|
Took me a minute to fully understand. The 👍 |
gmacdougall
added a commit
that referenced
this pull request
Mar 3, 2016
…usting Only check once whether we're in a non-default non-order zone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling Spree::TaxRate#adjust, Spree::TaxRate#compute_amount will
come up with negative amount only if we're processing a refund. This commit
checks for the amount of the reimbursement to be negative instead of running
a rather expensive call to Spree::Zone.contains.