Have Spree::Product#prices return master prices#969
Merged
gmacdougall merged 1 commit intomasterfrom Mar 10, 2016
unknown repository
Merged
Have Spree::Product#prices return master prices#969gmacdougall merged 1 commit intomasterfrom unknown repository
gmacdougall merged 1 commit intomasterfrom
unknown repository
Conversation
Member
|
Can you please add a changelog entry for this. It is a change in behaviour that I think people would want to know about. |
Contributor
Author
|
Added the changelog entry, and rebased on #935 in anticipation of the next merge conflict. |
Member
|
👍 For the code from me. Although would have rather not had this re-based on #935 so that this wasn't dependent on another change getting merged first. |
Contributor
Author
|
@adammathys Rebased against master again. |
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
All other associations are `:through variants_including_master`, this one strangely is not.
Contributor
Author
|
Rebased on current master, added link to PR to changelog. |
gmacdougall
added a commit
that referenced
this pull request
Mar 10, 2016
Have Spree::Product#prices return master prices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other associations are
:through variants_including_master, thisone strangely is not.