Assign a line items currency as an attribute, not an option#993
Conversation
When extracting pricing to service objects I came across a number of ways of setting a line item's currency. In `OrderContents`, the currency, although an attribute of the line item, is passed to the line item through an options Hash designed for an extension point introduced around Spree 2.2/2.3 while it could just be assigned directly like any other attribute. This PR refactors that bit of weird code, hopefully relieving us of the `options=` method on line item entirely in the future.
Contributor
|
👍 |
Contributor
Author
|
Also closing this in favour of #998. We don't even need this attribute, and it only creates confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extracting pricing to service objects I came across a number of
ways of setting a line item's currency. In
OrderContents, the currency,although an attribute of the line item, is passed to the line item
through an options Hash designed for an extension point introduced around
Spree 2.2/2.3 while it could just be assigned directly like any other
attribute.
This PR refactors that bit of weird code, hopefully relieving us of the
options=method on line item entirely in the future.