Get line item currency from order#995
Closed
Conversation
There seems to be a way of obtaining a line item's currency from it's variant. That doesn't make much sense, as a variant might have many prices in different currencies, but is not tied to a user or an order which would know WHICH of those currencies to use. Yanked an occurrence of `variant.currency` for `order.currency`.
Member
|
👍 |
Contributor
|
👍 Yikes. |
Member
|
👍 |
Contributor
|
No specs? |
Contributor
Author
Contributor
|
@mamhoff This project currently does not automatically verify code changes are paired with covering specs. While people seem to review code changes, the reviews are naturally (as we are all humans) of varying quality. Having even an imperfect automated system in place that verifies the semantic change coverage will trigger the humans into performing a much higher quality review, as such systems never have a bad day. When we have our tax hangout, I might be able to convince you to put such a system in-place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a way of obtaining a line item's currency from
it's variant. That doesn't make much sense, as a variant might have
many prices in different currencies, but is not tied to a user or an
order which would know which of those currencies to use.