Add ffaker dependency to gemspec#109
Merged
stewart merged 2 commits intosolidusio:masterfrom Sep 12, 2017
swcraig:add-ffaker-dependency
Merged
Add ffaker dependency to gemspec#109stewart merged 2 commits intosolidusio:masterfrom swcraig:add-ffaker-dependency
stewart merged 2 commits intosolidusio:masterfrom
swcraig:add-ffaker-dependency
Conversation
ffaker was removed as a runtime dependency of Solidus. polyglot (which is a dependency of deface) is raising a LoadError when it tries to require ffaker, which is not defined. PR removing ffaker from Solidus: solidusio/solidus#2140
stewart
approved these changes
Sep 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffaker was removed as a runtime dependency of Solidus.
polyglot (which is a dependency of deface) is raising a LoadError when
it tries to require ffaker, which is not defined.
PR removing ffaker from Solidus:
solidusio/solidus#2140
I only add ffaker and alphabetize the dev dependencies in this PR.