Update to the latest solidus_dev_support defaults #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/dev-support-update
branch
4 times, most recently
from
723fe93 to
5be7fd3
Compare
elia
force-pushed
the
elia/dev-support-update
branch
from
5be7fd3 to
19fac8d
Compare
An additional install generator has been added using the extension's namespace for consistency with the other extensions and for easier future upgrades.
elia
force-pushed
the
elia/dev-support-update
branch
from
19fac8d to
d2a1096
Compare
jarednorman
approved these changes
Sep 12, 2022
Member
jarednorman
left a comment
jarednorman
left a comment
There was a problem hiding this comment.
Are we worried about the namespace change causing upgrade or compatibility issues for stores?
Member
Author
|
@jarednorman it's intended to be completely transparent, with all the older files still supported, but to also open up to a future deprecation of spree/auth in favor of the namespace matching the gem name. After all adding it to the Gemfile already triggered a |
kennyadsl
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long overdue update to the extension in order to get rid of the boilerplate in favor of more usage
solidus_dev_supporthelpers.All changes not strictly coming from running
solidus extension .are listed in separate commits.Among them are: