Run the CI on all supported ruby versions #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/ci-ruby-versions
branch
3 times, most recently
from
a01931e to
38621f2
Compare
`solidus_bolt` needs to be disabled for the dummy app otherwise it fails due to the contrived nature of the app. For rubies < 3 using the latest rails we need to use the external net/http gem to avoid this error: rake aborted! LoadError: cannot load such file -- net/smtp /home/circleci/project/vendor/bundle/v3.1/ruby/3.1.0/gems/activesupport-6.1.6.1/lib/active_support/dependencies.rb:332:in `require' /home/circleci/project/vendor/bundle/v3.1/ruby/3.1.0/gems/activesupport-6.1.6.1/lib/active_support/dependencies.rb:332:in `block in require' /home/circleci/project/vendor/bundle/v3.1/ruby/3.1.0/gems/activesupport-6.1.6.1/lib/active_support/dependencies.rb:299:in `load_dependency' /home/circleci/project/vendor/bundle/v3.1/ruby/3.1.0/gems/activesupport-6.1.6.1/lib/active_support/dependencies.rb:332:in `require' /home/circleci/project/vendor/bundle/v3.1/ruby/3.1.0/gems/mail-2.7.1/lib/mail.rb:9:in `<module:Mail>' /home/circleci/project/vendor/bundle/v3.1/ruby/3.1.0/gems/mail-2.7.1/lib/mail.rb:3:in `<top (required)>' Ref rails/rails#44175 (comment)
elia
force-pushed
the
elia/ci-ruby-versions
branch
2 times, most recently
from
1f0363c to
5954ea9
Compare
jarednorman
approved these changes
Sep 9, 2022
spaghetticode
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.