Update CI configuration #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI should be fine once we release a new version of solidus_dev_support with solidusio/solidus_dev_support#205 |
waiting-for-dev
force-pushed
the
waiting-for-dev/fix_ci
branch
from
04aa2de to
6cb5129
Compare
Run different Solidus versions on different jobs for better error handling. We're now explicitly providing the ruby version to the executor while using a matrix configuration for better extensibility. We're now running the linter on Ruby v3.0, as that's the minimal requirement for Solidus master. As a consequence, we disable the cop for following the gemspec version.
Member
|
@waiting-for-dev I think we need to remove this line: . It's not needed anymore, now that we havesolidus_auth_devise/spec/spec_helper.rb Line 24 in 97342f7 |
That's not needed anymore, as we're now using `.load_for` method. See d2a1096
waiting-for-dev
force-pushed
the
waiting-for-dev/fix_ci
branch
from
6cb5129 to
19e8abc
Compare
Contributor
Author
Good call. Changed! |
kennyadsl
approved these changes
May 3, 2023
elia
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run different Solidus versions on different jobs for better error handling.
We're now explicitly providing the ruby version to the executor while using a matrix configuration for better extensibility.
We're now running the linter on Ruby v3.0, as that's the minimal requirement for Solidus master. As a consequence, we disable the cop for following the gemspec version.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: