Skip to content

Update proposed defaults#191

Merged
kennyadsl merged 12 commits intomasterfrom
elia/updates
Dec 20, 2022
Merged

Update proposed defaults#191
kennyadsl merged 12 commits intomasterfrom
elia/updates

Conversation

@elia
Copy link
Copy Markdown
Member

@elia elia commented Oct 10, 2022

Modernize version numbers and recognize improvements implemented in multiple downstream extensions.

Summary

Mostly changes to the sandbox script and the CI config.

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.

@elia elia self-assigned this Oct 10, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 10, 2022

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Oct 10, 2022
@elia elia added enhancement Improves an existing feature. and removed needs changelog label Needs a label to determine the type of change. labels Oct 10, 2022
@elia elia force-pushed the elia/updates branch 7 times, most recently from 58ff1de to 551eab0 Compare October 17, 2022 12:09
elia and others added 6 commits December 14, 2022 18:25
Otherwise it will exit with 0 in any case.
Co-Authored-By: Marc Busqué <marc@lamarciana.com>
The command `solidus extension .` may not work directly on some machines
without `bundle exec`. Updated to be more explicit and prevent possible
confusion.
elia added 2 commits December 14, 2022 18:35
Only allow those compatible with `rails new --database=…` except for
`sqlite` that is transformed to `sqlite3` so it continues to work with
the CircleCI ORB.
It was redundant with instructions from the wiki page on releasing.
@elia elia marked this pull request as ready for review December 14, 2022 18:07
This avoids using the most recent ruby on solidus versions that barely
support it.
@elia elia marked this pull request as draft December 15, 2022 15:57
elia added 2 commits December 19, 2022 13:50
It's faster and that's the default browser for specs.
@elia elia marked this pull request as ready for review December 19, 2022 14:27
@kennyadsl kennyadsl merged commit 55b738c into master Dec 20, 2022
@kennyadsl kennyadsl deleted the elia/updates branch December 20, 2022 11:48
forkata pushed a commit to SuperGoodSoft/solidus_dev_support that referenced this pull request Mar 12, 2026
Add missing FR `spree.admin_login` translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants