Conversation
Contributor
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
58ff1de to
551eab0
Compare
Otherwise it will exit with 0 in any case.
Co-Authored-By: Marc Busqué <marc@lamarciana.com>
The command `solidus extension .` may not work directly on some machines without `bundle exec`. Updated to be more explicit and prevent possible confusion.
Only allow those compatible with `rails new --database=…` except for `sqlite` that is transformed to `sqlite3` so it continues to work with the CircleCI ORB.
It was redundant with instructions from the wiki page on releasing.
This avoids using the most recent ruby on solidus versions that barely support it.
It's faster and that's the default browser for specs.
kennyadsl
approved these changes
Dec 20, 2022
forkata
pushed a commit
to SuperGoodSoft/solidus_dev_support
that referenced
this pull request
Mar 12, 2026
Add missing FR `spree.admin_login` translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize version numbers and recognize improvements implemented in multiple downstream extensions.
Summary
Mostly changes to the sandbox script and the CI config.
Checklist