Skip to content

Fix sandbox default solidus branch #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Nov 9, 2022
Merged

Fix sandbox default solidus branch #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef20862
Fix sandbox.tt variable comparison usage
RyanofWoods Nov 9, 2022
611a98f
Refactor sandbox.tt
RyanofWoods Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions lib/solidus_dev_support/templates/extension/bin/sandbox.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

set -e
if [ ! -z $DEBUG ]
if [ -n "$DEBUG" ]
then
set -x
fi
Expand All @@ -28,16 +28,14 @@ sqlite3|sqlite)
esac
echo "~~> Using $RAILSDB as the database engine"

if [ -n $SOLIDUS_BRANCH ]
if [ -z "$SOLIDUS_BRANCH" ]
then
BRANCH=$SOLIDUS_BRANCH
else
echo "~~> Use 'export SOLIDUS_BRANCH=[master|v3.2|...]' to control the Solidus branch"
BRANCH="master"
SOLIDUS_BRANCH="master"
fi
echo "~~> Using branch $BRANCH of solidus"
echo "~~> Using branch $SOLIDUS_BRANCH of solidus"

if [ -z $SOLIDUS_FRONTEND ]
if [ -z "$SOLIDUS_FRONTEND" ]
then
echo "~~> Use 'export SOLIDUS_FRONTEND=[solidus_frontend|solidus_starter_frontend]' to control the Solidus frontend"
SOLIDUS_FRONTEND="solidus_frontend"
Expand Down Expand Up @@ -68,7 +66,7 @@ fi

cd ./sandbox
cat <<RUBY >> Gemfile
gem 'solidus', github: 'solidusio/solidus', branch: '$BRANCH'
gem 'solidus', github: 'solidusio/solidus', branch: '$SOLIDUS_BRANCH'
gem 'rails-i18n'
gem 'solidus_i18n'

Expand Down