Skip to content

Add Solidus Auth Devise to Sandbox script#210

Merged
kennyadsl merged 1 commit intosolidusio:masterfrom
mamhoff:add-solidus-auth-to-sandbox
Jun 22, 2023
Merged

Add Solidus Auth Devise to Sandbox script#210
kennyadsl merged 1 commit intosolidusio:masterfrom
mamhoff:add-solidus-auth-to-sandbox

Conversation

@mamhoff
Copy link
Copy Markdown
Contributor

@mamhoff mamhoff commented Jun 15, 2023

Summary

Without adding the gem, the rake solidus:auth:install command further down the script will fail.

Checklist

Without adding the gem, the `rake solidus:auth:install` command further
down the script will fail.
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jun 15, 2023

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Jun 15, 2023
Copy link
Copy Markdown
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamhoff the whole file is outdated, this will only work with versions of solidus prior to 4, maybe not even some 3.x are compatible.

Which solidus versions are you targeting?

@elia elia self-assigned this Jun 15, 2023
@mamhoff
Copy link
Copy Markdown
Contributor Author

mamhoff commented Jun 15, 2023

It's true, I'm running into MANY problems with the script. I'm targeting current main.

Copy link
Copy Markdown
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sandbox script, as other parts of dev support needs a deeper refresh after the release of solidus 4, but meanwhile this can probably save the day in a few situations 🙌

@elia elia requested a review from kennyadsl June 15, 2023 15:28
@kennyadsl kennyadsl merged commit d6648b8 into solidusio:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changelog label Needs a label to determine the type of change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants