Adapt sandbox script to solidus 4#212
Merged
kennyadsl merged 1 commit intosolidusio:masterfrom Jun 22, 2023
Merged
Conversation
Contributor
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
ddc642e to
244e0d9
Compare
The sandbox script has been updated in core, and this takes the changes from there and adds them to the bin/sandbox template.
244e0d9 to
0b72258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The automatically generated
bin/sandboxscript does not work with current Solidus any longer. This upgrades the script to work with (at least) Solidus 4.It also provides a Rake task to help you obtain this script in existing extensions. From the root of your extension, run
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: