Remove dependency on the webdrivers gem#213
Merged
mergify[bot] merged 1 commit intosolidusio:mainfrom Oct 18, 2023
Merged
Conversation
mergify
Bot
added
the
needs changelog label
Contributor
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
Contributor
|
@jarednorman If you rebase this against |
jarednorman
force-pushed
the
rip-webdrivers
branch
from
dbc969a to
8253236
Compare
Member
Author
|
Thanks, done. |
adammathys
approved these changes
Oct 18, 2023
Member
adammathys
left a comment
adammathys
left a comment
There was a problem hiding this comment.
Minus the one linting issue, this looks good to me!
| spec.add_dependency 'rubocop-rspec', '~> 2.0' | ||
| spec.add_dependency 'solidus_core', ['>= 2.0', '< 5'] | ||
| spec.add_dependency 'webdrivers', '>= 4.4' | ||
| spec.add_dependency 'selenium-webdriver', '~> 4.11' |
Member
There was a problem hiding this comment.
Our linting is complaining that this line should be one higher to keep this list alphabetical. ❤️
webdrivers no longer works with recent versions of Chrome. Recent versions of selenium-webdriver (newer than 4.11) achieve the same effect. One caveat with this change: it implicitly requires Ruby 3 as that's the requirement for selenium-webdriver 4.11+.
jarednorman
force-pushed
the
rip-webdrivers
branch
from
8253236 to
6f67dbc
Compare
adammathys
added
infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The webdrivers gem no longer works with recent versions of Chrome. Recent versions of selenium-webdriver (newer than 4.11) achieve the same effect.
One caveat with this change: it implicitly requires Ruby 3 as that's the requirement for selenium-webdriver 4.11+.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: