Skip to content

Update solidus-older CI tasks to use Ruby 3#214

Merged
mergify[bot] merged 2 commits intosolidusio:mainfrom
SuperGoodSoft:solidus-order-ruby-3
Oct 17, 2023
Merged

Update solidus-older CI tasks to use Ruby 3#214
mergify[bot] merged 2 commits intosolidusio:mainfrom
SuperGoodSoft:solidus-order-ruby-3

Conversation

@benjaminwil
Copy link
Copy Markdown
Contributor

Summary

Ruby 2.7 has been end-of-lifed: https://endoflife.date/ruby.

Checklist

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Oct 17, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 17, 2023

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

The `lint-code` CI job failed for this reason:

    lib/solidus_dev_support/rake_tasks.rb:86:1: C: [Correctable]
    Layout/EmptyLinesAroundExceptionHandlingKeywords:
    Extra empty line detected before the rescue.
    (https://rubystyle.guide#empty-lines-around-bodies)
@adammathys adammathys added infrastructure Internal change — changelog entry not needed. and removed needs changelog label Needs a label to determine the type of change. labels Oct 17, 2023
@mergify mergify Bot merged commit 0794cc1 into solidusio:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Internal change — changelog entry not needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants