Skip to content

Allow Puma 6#216

Merged
mergify[bot] merged 2 commits intosolidusio:mainfrom
mamhoff:allow-puma-6
Jan 16, 2024
Merged

Allow Puma 6#216
mergify[bot] merged 2 commits intosolidusio:mainfrom
mamhoff:allow-puma-6

Conversation

@mamhoff
Copy link
Copy Markdown
Contributor

@mamhoff mamhoff commented Jan 16, 2024

Summary

Puma 6 was disallowed in 2022, because back then Rails itself generated Gemfiles with `'puma', "< 6". This is not the case anymore, in fact, Rails comes with Rack 3 which instead is incompatible with Puma 5.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

Puma 6 was disallowed in 2022, because back then Rails itself generated
Gemfiles with `'puma', "< 6". This is not the case anymore, in fact,
Rails comes with Rack 3 which instead is incompatible with Puma 5.
@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Jan 16, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 16, 2024

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@tvdeyen tvdeyen added enhancement Improves an existing feature. and removed needs changelog label Needs a label to determine the type of change. labels Jan 16, 2024
@mergify mergify Bot merged commit b1b9aab into solidusio:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants