Skip to content

Restrict SQLite to 1.x#219

Merged
mergify[bot] merged 1 commit intosolidusio:mainfrom
mamhoff:restrict-sqlite
Jun 17, 2024
Merged

Restrict SQLite to 1.x#219
mergify[bot] merged 1 commit intosolidusio:mainfrom
mamhoff:restrict-sqlite

Conversation

@mamhoff
Copy link
Copy Markdown
Contributor

@mamhoff mamhoff commented Jun 17, 2024

They just released sqlite3 2.0.0, but ActiveRecord's sqlite3 adapter doesn't know about this yet, leading to conflicting sqlite3 gems in specs.

This is probably a temporary fix until ActiveRecord learns the news.

See https://github.com/rails/rails/blob/main/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14 and https://github.com/sparklemotion/sqlite3-ruby/blob/main/CHANGELOG.md

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Jun 17, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jun 17, 2024

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@tvdeyen tvdeyen added bug Describes or fixes a bug. and removed needs changelog label Needs a label to determine the type of change. labels Jun 17, 2024
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

They just released sqlite3 2.0.0, but ActiveRecord's sqlite3 adapter doesn't know about this yet, leading to conflicting sqlite3 gems in specs.

This is probably a temporary fix until ActiveRecord learns the news.

See https://github.com/rails/rails/blob/main/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
and https://github.com/sparklemotion/sqlite3-ruby/blob/main/CHANGELOG.md
@mergify mergify Bot merged commit fc9b4f3 into solidusio:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Describes or fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants