Allow passing a user class to the test app generator#222
Merged
mergify[bot] merged 2 commits intosolidusio:mainfrom Dec 3, 2024
Merged
Allow passing a user class to the test app generator#222mergify[bot] merged 2 commits intosolidusio:mainfrom
mergify[bot] merged 2 commits intosolidusio:mainfrom
Conversation
Contributor
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
mergify
Bot
added
the
needs changelog label
mamhoff
force-pushed
the
allow-passing-user-class-for-test-app
branch
from
03d369c to
18e6dd9
Compare
tvdeyen
added
enhancement
Currently, solidus_auth_devise is tested with a dummy app that specifies `Spree::LegacyUser` in its `spree.rb initializer. That's not great, but there's no way of fixing it if the rake task install does not pass through the user class option. The way to use this feature would be in an extension's Rakefile: ```rb SolidusDevSupport::RakeTasks.install(user_class: "Spree::User") ```
The Gemfile that's generated for testing extensions contains solidus_auth_devise, which sets the user class for the app to Spree::User. The generator in this Rakefile should be set up to do the same.
mamhoff
force-pushed
the
allow-passing-user-class-for-test-app
branch
from
a16f047 to
a498d16
Compare
tvdeyen
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, solidus_auth_devise is tested with a dummy app that specifies
Spree::LegacyUserin its `spree.rb initializer. That's not great, but there's no way of fixing it if the rake task install does not pass through the user class option.