Merged
Conversation
Contributor
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
mergify
Bot
added
the
needs changelog label
tvdeyen
added
enhancement
tvdeyen
force-pushed
the
use-github-actions
branch
7 times, most recently
from
06c6ee3 to
5884f1f
Compare
We want to migrate away from circle ci
Rails 7.0 is untestable because the rails _7.0_ new command fails because of a bug that has not been fixed in the published rails gem and wont be ever. Since rails 7.0 will be eol in 6 weeks it does not make sense to waste carbon on it.
The sandbox wants to install Solidus and migrate before running the install generator. That's bad, because migrating requires the app to boot, and booting fails because Sprockets fails with an error if the `manifest.js` file is not present. Since the file is quite simple, we can just pass it into a heredoc. This is needed for Rails 8, where the install generator won't create the file for us.
tvdeyen
force-pushed
the
use-github-actions
branch
from
82014ca to
c2b4db4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run this extensions own specs on GH actions and generate new extensions to run their specs on GH as well.
Drops CI builds for Solidus 4.1 and 4.2 due to the fact that Rails 7.0 cannot be installed anymore, because of
bug caused by the concurrent-ruby gem which has been fixed and merged but not released as gem and never will, because Rails 7.0 is out of support and will reach EOL on April, 1 2025.
This adds builds against Solidus v4.5, main (4.6.0.a) and Rails 8.0 so that we can test extensions with upcoming Solidus releases.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: