Conversation
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
===========================================
- Coverage 92.3% 30.23% -62.08%
===========================================
Files 2 5 +3
Lines 13 43 +30
===========================================
+ Hits 12 13 +1
- Misses 1 30 +29
Continue to review full report at Codecov.
|
bd49527 to
0e23025
Compare
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 11 11
=====================================
Hits 11 11Continue to review full report at Codecov.
|
0e23025 to
8b9f703
Compare
aldesantis
left a comment
There was a problem hiding this comment.
@elia I'm okay with the bin files, but not a huge fan of Overcommit tbh. I find that using that kind of tool slows down development because you often don't want to run checks for each commit, but only on the final PR, which is where Hound and similar come in handy.
Since most SaaS tools are free for open source projects, I think we're better off simply enforcing Hound on all solidusio(-contrib) repositories, which will probably be a part of #5.
In the meantime, could you split the two changes so that we can merge the bin files right away and keep Overcommit on hold for the time being?
|
@aldesantis sure, I'll extract overcommit, my take is that I hate the noise that hound generates on the PR and the earlier I get feedback the better, also I would encourage having linted code in each commit, and delgate to the use of But of course Hound will be way faster than checking rubocop as part of the CI. 👍 |
8b9f703 to
0cd7d56
Compare
This way optparse will be able to parse and check options right away and -h will be almost instantaneous.
Just for convenience and consistency with the other development commands.
This will make all commands work because they're executed from the app's root. Removed the .tt extension as it has no interpolations to apply.
0cd7d56 to
0b8dd1f
Compare
Completely excluded tmp/ and disabled the frozen magic for bin & exe files.
0b8dd1f to
2177791
Compare
The code has been taken from Bundler.
2177791 to
5fee8ae
Compare
Generate bin/rails bin/rake bin/setup bin/update bin/console scripts, possibly also bin/server and bin/release (see the original PR)
bin/serverbecausebin/rails sis easy enough.bin/releasebecause the release procedure it's not clear yet.Ref: #11