Skip to content

Generate bin files#35

Merged
aldesantis merged 7 commits intomasterfrom
elia/generate-bin-files
Jan 10, 2020
Merged

Generate bin files#35
aldesantis merged 7 commits intomasterfrom
elia/generate-bin-files

Conversation

@elia
Copy link
Copy Markdown
Member

@elia elia commented Dec 13, 2019

Generate bin/rails bin/rake bin/setup bin/update bin/console scripts, possibly also bin/server and bin/release (see the original PR)

  • Won't add bin/server because bin/rails s is easy enough.
  • Won't add bin/release because the release procedure it's not clear yet.
  • Overcommit has been added to run checks (including Rubocop) before commits

Ref: #11

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 13, 2019

Codecov Report

Merging #35 into master will decrease coverage by 62.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #35       +/-   ##
===========================================
- Coverage    92.3%   30.23%   -62.08%     
===========================================
  Files           2        5        +3     
  Lines          13       43       +30     
===========================================
+ Hits           12       13        +1     
- Misses          1       30       +29
Impacted Files Coverage Δ
...olidus_test_extension/install/install_generator.rb 0% <0%> (ø)
lib/solidus_test_extension/factories.rb 100% <0%> (ø)
lib/solidus_test_extension/version.rb 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b000b1f...0e23025. Read the comment docs.

@elia elia marked this pull request as ready for review December 13, 2019 13:22
@elia elia force-pushed the elia/generate-bin-files branch from bd49527 to 0e23025 Compare December 13, 2019 17:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 13, 2019

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          11     11           
=====================================
  Hits           11     11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b33a25...5fee8ae. Read the comment docs.

@elia elia force-pushed the elia/generate-bin-files branch from 0e23025 to 8b9f703 Compare December 27, 2019 14:39
Copy link
Copy Markdown
Member

@aldesantis aldesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia I'm okay with the bin files, but not a huge fan of Overcommit tbh. I find that using that kind of tool slows down development because you often don't want to run checks for each commit, but only on the final PR, which is where Hound and similar come in handy.

Since most SaaS tools are free for open source projects, I think we're better off simply enforcing Hound on all solidusio(-contrib) repositories, which will probably be a part of #5.

In the meantime, could you split the two changes so that we can merge the bin files right away and keep Overcommit on hold for the time being?

@elia
Copy link
Copy Markdown
Member Author

elia commented Jan 3, 2020

@aldesantis sure, I'll extract overcommit, my take is that I hate the noise that hound generates on the PR and the earlier I get feedback the better, also I would encourage having linted code in each commit, and delgate to the use of -n where it should be skipped.

But of course Hound will be way faster than checking rubocop as part of the CI. 👍

@elia elia force-pushed the elia/generate-bin-files branch from 8b9f703 to 0cd7d56 Compare January 3, 2020 17:24
elia added 3 commits January 3, 2020 18:29
This way optparse will be able to parse and check options right away
and -h will be almost instantaneous.
Just for convenience and consistency with the other development
commands.
This will make all commands work because they're executed from the
app's root.

Removed the .tt extension as it has no interpolations to apply.
@elia elia force-pushed the elia/generate-bin-files branch from 0cd7d56 to 0b8dd1f Compare January 3, 2020 17:29
elia added 3 commits January 3, 2020 18:41
Completely excluded tmp/ and disabled the frozen magic for bin & exe
files.
@elia elia force-pushed the elia/generate-bin-files branch from 0b8dd1f to 2177791 Compare January 3, 2020 17:41
@elia elia requested a review from aldesantis January 3, 2020 17:57
The code has been taken from Bundler.
@elia elia force-pushed the elia/generate-bin-files branch from 2177791 to 5fee8ae Compare January 3, 2020 17:58
@aldesantis aldesantis merged commit 667c9c7 into master Jan 10, 2020
@aldesantis aldesantis deleted the elia/generate-bin-files branch January 10, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants