Skip to content

Adopt Bundler gemspec defaults in the generated extension#53

Merged
aldesantis merged 1 commit intomasterfrom
aldesantis/11-bundler-gemspec-defaults
Jan 10, 2020
Merged

Adopt Bundler gemspec defaults in the generated extension#53
aldesantis merged 1 commit intomasterfrom
aldesantis/11-bundler-gemspec-defaults

Conversation

@aldesantis
Copy link
Copy Markdown
Member

Fixes #11.

Summary

Adopts some more Bundler gemspec defaults in the gemspec of the generated extension.

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.
  • I have added an entry to the changelog for this change.

@aldesantis aldesantis self-assigned this Jan 10, 2020
@aldesantis aldesantis requested a review from elia January 10, 2020 09:29
@aldesantis aldesantis force-pushed the aldesantis/11-bundler-gemspec-defaults branch from 517e2d7 to 59e9498 Compare January 10, 2020 09:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2020

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #53   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          11     11           
=====================================
  Hits           11     11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c31f0...59e9498. Read the comment docs.

@aldesantis aldesantis merged commit aec5c7e into master Jan 10, 2020
@aldesantis aldesantis deleted the aldesantis/11-bundler-gemspec-defaults branch January 10, 2020 10:15
Comment thread spec/features/create_extension_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backport to dev_tools the tooling added to solidus_static_content

3 participants