Ransack searchable attribute issue in admin#301
Merged
tvdeyen merged 2 commits intosolidusio:mainfrom Jun 25, 2024
Merged
Conversation
tvdeyen
reviewed
Jun 19, 2024
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Thanks. There are many attributes that do not need to be searchable. Can we scope the fields to the ones we really need?
tvdeyen
reviewed
Jun 20, 2024
Contributor
Author
|
@tvdeyen Are we good to merge these changes? |
Member
|
Test failures not related to this change. Need to tackle those in another PR |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue - Runtime Error in Spree::Admin::Subscriptions. Ransack needs Solidus Subscriptions, Installments, Events attributes explicitly allowlisted as searchable
Fixes - Added the methods to make subscriptions, installments, events attributes allowlisted as searchable.
Checklist