Merged
Conversation
tvdeyen
added a commit
to tvdeyen/solidus
that referenced
this pull request
Dec 17, 2024
solidus_support 0.11.0 introduced flickwerk for patch loading. Somehow this messes with the zeitwerk autoloader and things acting weird (inflections broken, wrong constant module nesting, etc.) Revert happens in solidusio/solidus_support#93 This commit is for testing that the revert works.
tvdeyen
added a commit
to tvdeyen/solidus
that referenced
this pull request
Dec 17, 2024
solidus_support 0.11.0 introduced flickwerk for patch loading. Somehow this messes with the zeitwerk autoloader and things acting weird (inflections broken, wrong constant module nesting, etc.) Revert happens in solidusio/solidus_support#93 This commit is for testing that the revert works.
spaghetticode
approved these changes
Dec 17, 2024
Member
Author
|
tested with solidusio/solidus#6037 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #90 and #92
Somehow the flickwerk dependency breaks many extensions and core gems in the whole Solidus ecosystem.
Symptoms so far
Let's revert and then investigate what is happening