Improvements to the plotly3D.pl macro.#1
Merged
somiaj merged 1 commit intosomiaj:plotly3Dfrom Mar 13, 2023
Merged
Conversation
drgrice1
force-pushed
the
plotly3D-improvements
branch
3 times, most recently
from
32086d6 to
e14771f
Compare
…ames. Instead scope those sections properly in the javascript so that static variable names can be used. The only thing the unique id is really needed for is to have a unique html id for the containing div. This makes the generated javascript smaller since that generated id is quite long. Also fix the funcType 'perl' option. The funcType 'perl' and funcType 'data' need better documentation. Also update the package-lock.json file. Something wasn't done right there as running `npm install` modifies the lock file. Finally, update the loading method in javascript to work for webwork3 and similar rendering techniques where the javascript will be added to the page after the DOMContentLoaded event has already run.
drgrice1
force-pushed
the
plotly3D-improvements
branch
from
e14771f to
259c084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to use the getUniqueName generated id for variable names.
Instead scope those sections properly in the javascript so that static variable names can be used. The only thing the unique id is really needed for is to have a unique html id for the containing div. This makes the generated javascript smaller since that generated id is quite long.
Also fix the funcType 'perl' option.
The funcType 'perl' and funcType 'data' need better documentation.
Also update the package-lock.json file. Something wasn't done right there as running
npm installmodifies the lock file.