Skip to content

Conversation

@devesh-nexthop
Copy link

What I did

Add support for WRED yellow and green parameters.

How I did it

Added these parameters to operation validators config.

How to verify it

Applied below config with apply-patch:

cat config_wred.json
[ 
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_min_threshold",
    "value": "524288"
  },
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_max_threshold",
    "value": "1048576"
  },
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_min_threshold",
    "value": "524288"
  },
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_max_threshold",
    "value": "1048576"
  },
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_max_threshold",
    "value": "1048576"
  },
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_drop_probability",
    "value": "15"
  },
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_drop_probability",
    "value": "15"
  },
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_drop_probability",
    "value": "15"
  },
  { 
    "op": "replace",
    "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_min_threshold",
    "value": "524288"
  }
]

Verified that config gets applied without any error:

sudo config apply-patch config_wred.json 
Patch Applier: localhost: Patch application starting.
Patch Applier: localhost: Patch: [{"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_min_threshold", "value": "524288"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_max_threshold", "value": "1048576"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_min_threshold", "value": "524288"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_max_threshold", "value": "1048576"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_max_threshold", "value": "1048576"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_drop_probability", "value": "15"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_drop_probability", "value": "15"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_drop_probability", "value": "15"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_min_threshold", "value": "524288"}]
Patch Applier: localhost getting current config db.
Patch Applier: localhost: simulating the target full config after applying the patch.
Patch Applier: localhost: validating all JsonPatch operations are permitted on the specified fields
Patch Applier: localhost: validating target config does not have empty tables,
                            since they do not show up in ConfigDb.
Patch Applier: localhost: sorting patch updates.
Patch Applier: The localhost patch was converted into 1 change:
Patch Applier: localhost: applying 1 change in order:
Patch Applier:   * [{"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_drop_probability", "value": "15"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_max_threshold", "value": "1048576"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/green_min_threshold", "value": "524288"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_drop_probability", "value": "15"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_max_threshold", "value": "1048576"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/red_min_threshold", "value": "524288"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_drop_probability", "value": "15"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_max_threshold", "value": "1048576"}, {"op": "replace", "path": "/WRED_PROFILE/AZURE_LOSSLESS/yellow_min_threshold", "value": "524288"}]
Patch Applier: localhost: verifying patch updates are reflected on ConfigDB.
Patch Applier: localhost patch application completed.
Patch applied successfully.

closes sonic-net/sonic-buildimage#24933

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@mssonicbld
Copy link
Collaborator

/azp run

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Devesh Pathak <250206677+devesh-nexthop@users.noreply.github.com>
Signed-off-by: Devesh Pathak <250206677+devesh-nexthop@users.noreply.github.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: GCU operation fails for WRED_PROFILE changes (Yellow/Red Parameters)

2 participants